Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds "Check Point" of code at first "watch it fail" section #101

Merged
merged 1 commit into from
Aug 3, 2017
Merged

adds "Check Point" of code at first "watch it fail" section #101

merged 1 commit into from
Aug 3, 2017

Conversation

nelsonic
Copy link
Member

see: #100

@nelsonic nelsonic assigned ghost Jul 30, 2017
@codecov
Copy link

codecov bot commented Jul 30, 2017 •
edited
Loading

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          33     33           
=====================================
  Hits           33     33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbdc58...0fa2c27. Read the comment docs.

ghost
ghost approved these changes Jul 30, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonic looks good! 👍

@ghost ghost assigned iteles and unassigned ghost Jul 30, 2017
@ghost ghost requested a review from iteles July 30, 2017 20:08
iteles
iteles approved these changes Aug 3, 2017
View reviewed changes
Copy link
Member

@iteles iteles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry I didn't see this sooner!
Looks great!
🙏

@iteles iteles merged commit 8c650f6 into master Aug 3, 2017
@iteles iteles deleted the watch-it-fail-sample-code-issue-100 branch August 3, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

Assignees

@iteles iteles

Labels
awaiting-review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @iteles